Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): implement readAsset #694

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(deno): implement readAsset #694

merged 2 commits into from
Dec 5, 2022

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Nov 25, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@so1ve
Copy link
Contributor Author

so1ve commented Nov 25, 2022

I'm not sure if path.join should be used instead of hardcoded id.

Also, it seems that process.env is not replaced by Deno.env.toObject() in the deno preset

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #694 (4eefb24) into main (44c10fa) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files          57       57           
  Lines        4232     4232           
  Branches      459      459           
=======================================
  Hits         2832     2832           
  Misses       1397     1397           
  Partials        3        3           
Impacted Files Coverage Ξ”
src/rollup/plugins/public-assets.ts 91.00% <0.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
Copy link
Member

pi0 commented Dec 5, 2022

I'm not sure if path.join should be used instead of hardcoded id.

id should be already normalized when passed to bundle. would be nice to double check it for windows however

Also, it seems that process.env is not replaced by Deno.env.toObject() in the deno press

Yeah we still need unenv/nitro preset for polyfills @danielroe is working on it. Feel free to open an issue for it.

@pi0 pi0 changed the title feat: implement deno assets fix(deno): implement readAsset Dec 5, 2022
@pi0 pi0 merged commit fc9f0e2 into nitrojs:main Dec 5, 2022
@so1ve
Copy link
Contributor Author

so1ve commented Dec 13, 2022

Hi @pi0,
actually deno provides official polyfills here: https://deno.land/std/node

@pi0
Copy link
Member

pi0 commented Dec 13, 2022

yes, std is what we need to port as unenv preset for mapping.

@BoxenOfDonuts BoxenOfDonuts mentioned this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants