-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deno): implement readAsset #694
Conversation
I'm not sure if path.join should be used instead of hardcoded id. Also, it seems that process.env is not replaced by Deno.env.toObject() in the deno preset |
Codecov Report
@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 57 57
Lines 4232 4232
Branches 459 459
=======================================
Hits 2832 2832
Misses 1397 1397
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
id should be already normalized when passed to bundle. would be nice to double check it for windows however
Yeah we still need unenv/nitro preset for polyfills @danielroe is working on it. Feel free to open an issue for it. |
Hi @pi0, |
yes, std is what we need to port as unenv preset for mapping. |
π Linked issue
β Type of change
π Description
π Checklist