fix(public-assets): do not shadow paths that share prefix #2516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Encountered this as a side effect of replicating another bug.
Registering public asset dir with a base URL of, say,
/custom
will lead to paths like/custom-thing
also being handled by the same handler (and returning a hard 404 if fallthrough is disabled). This is because we do not test if the path begins with/custom/
but with/custom
.Let me know if you need me to provide a reproduction. I think the problem and fix are straightforward to see, but happy to do so!
π Checklist