Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .tsx and .jsx to node-resolve extensions #2398

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

igorjacauna
Copy link
Contributor

πŸ”— Linked issue

Discussion: #2392

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds TSX/JSX to @rollup/plugin-node-resolve to allow import in routes/api files.

Here a StackBlitz reproduction based in the nano-jsx example.

When run the app, shows up RollupError: Could not resolve "../components/Hello" from "server/routes/index.tsx"

But if add the .jsx and .tsx to node-resolve it works

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title chore: Add JSX/TSX to Rollup plugin node-resolver fix: add .tsx and .jsx to node-resolve extensions Apr 29, 2024
@pi0 pi0 force-pushed the chore/add-jsx-rollup-resolver branch from f244162 to 6d54a08 Compare April 29, 2024 17:31
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pi0 pi0 merged commit d2c0d74 into nitrojs:main Apr 29, 2024
4 checks passed
pi0 pushed a commit to igorjacauna/nitro that referenced this pull request Apr 29, 2024
@pi0 pi0 mentioned this pull request Jun 13, 2024
pi0 pushed a commit that referenced this pull request Jun 27, 2024
@pi0 pi0 mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants