Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new underlining feature from #191 is a breaking change #203

Closed
trevor-vaughan opened this issue Jun 27, 2023 · 7 comments
Closed

The new underlining feature from #191 is a breaking change #203

trevor-vaughan opened this issue Jun 27, 2023 · 7 comments

Comments

@trevor-vaughan
Copy link

Environment

All

Reproduction

logger = require('consola')

myobj = { foo: 'my_content', bar: 'should_not_be_underlined' }
logger.log(myobj)

3.1.0 Output

{ foo: 'my_content', bar: 'should_not_be_underlined' }

3.2.0 Output

{ foo: 'mycontent', bar: 'shouldnotbeunderlined' }

Describe the bug

The console output from 3.2.0 does not match the output from 3.1.0.

Ideally, fancy formatting would be opt-in instead of opt-out at runtime.

Additional context

No response

Logs

No response

@trevor-vaughan
Copy link
Author

Ah, I see that I should use consola/basic instead.

@trevor-vaughan
Copy link
Author

Ah, no, I need to re-open this. I want the fancy formatting in terms of error messages, etc. But I definitely do not want object dumps to be processed as "fancy".

@trevor-vaughan
Copy link
Author

Hmm...this also causes issues with something as simple as My file names are some_thing.jpg and foo_bar.jpg

I would definitely prefer an opt-in to any delimiter-based options on a per-message basis. Otherwise, any dynamic content could cause a mess on output.

@pi0
Copy link
Member

pi0 commented Jun 27, 2023

Sorry for the regression. Fixing soon

image

@pi0 pi0 closed this as completed in bbed122 Jun 27, 2023
@trevor-vaughan
Copy link
Author

@pi0 No worries, appreciate both the awesome tool and rapid response :-D.

FWIW, I do like the concept that was introduced, I just think that it needs to be selectively opt-in.

@pi0
Copy link
Member

pi0 commented Jun 27, 2023

No worries. Can you please test with latest version? Is it still problematic for you?

@trevor-vaughan
Copy link
Author

@pi0 Good to go! Appreciate the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants