style: prefer object spread instead of Object.assign

unjs · Apr 10, 2023 · c03268a · c03268a
1 parent 1a4b893
commit c03268a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 28 deletions.
diff --git a/src/consola.ts b/src/consola.ts
@@ -101,25 +101,21 @@ export class Consola {
   }
 
   create(options: ConsolaOptions): ConsolaInstance {
-    return new Consola(
-      Object.assign(
-        {
-          reporters: this._reporters,
-          level: this.level,
-          types: this._types,
-          defaults: this._defaults,
-          stdout: this._stdout,
-          stderr: this._stderr,
-          mockFn: this._mockFn,
-        },
-        options
-      )
-    ) as ConsolaInstance;
+    return new Consola({
+      reporters: this._reporters,
+      level: this.level,
+      types: this._types,
+      defaults: this._defaults,
+      stdout: this._stdout,
+      stderr: this._stderr,
+      mockFn: this._mockFn,
+      ...options,
+    }) as ConsolaInstance;
   }
 
   withDefaults(defaults: ConsolaLogObject): ConsolaInstance {
     return this.create({
-      defaults: Object.assign({}, this._defaults, defaults),
+      defaults: { ...this._defaults, ...defaults },
     });
   }
 

diff --git a/src/reporters/basic.ts b/src/reporters/basic.ts
@@ -17,7 +17,7 @@ export default class BasicReporter {
   options: typeof DEFAULTS;
 
   constructor(options: Partial<typeof DEFAULTS>) {
-    this.options = Object.assign({}, DEFAULTS, options);
+    this.options = { ...DEFAULTS, ...options };
   }
 
   formatStack(stack: string) {

diff --git a/src/reporters/browser.ts b/src/reporters/browser.ts
@@ -7,7 +7,7 @@ export default class BrowserReporter {
   typeColorMap: Record<string, string>;
 
   constructor(options: any) {
-    this.options = Object.assign({}, options);
+    this.options = { ...options };
 
     this.defaultColor = "#7f8c8d"; // Gray
     this.levelColorMap = {

diff --git a/src/reporters/fancy.ts b/src/reporters/fancy.ts
@@ -24,7 +24,7 @@ const TYPE_ICONS = {
 
 export default class FancyReporter extends BasicReporter {
   constructor(options: Partial<typeof DEFAULTS>) {
-    super(Object.assign({}, DEFAULTS, options));
+    super({ ...DEFAULTS, ...options });
   }
 
   formatStack(stack: string) {

diff --git a/src/reporters/winston.ts b/src/reporters/winston.ts
@@ -19,16 +19,12 @@ export default class WinstonReporter {
     this.logger =
       logger && logger.log
         ? logger
-        : winston.createLogger(
-            Object.assign(
-              {
-                level: "info",
-                format: winston.format.simple(),
-                transports: [new winston.transports.Console()],
-              },
-              logger
-            )
-          );
+        : winston.createLogger({
+            level: "info",
+            format: winston.format.simple(),
+            transports: [new winston.transports.Console()],
+            ...logger,
+          });
   }
 
   log(logObj: ConsolaReporterLogObject) {