Skip to content
This repository has been archived by the owner on Sep 21, 2020. It is now read-only.

Clarify equals() #63

Closed
keilw opened this issue May 29, 2017 · 3 comments
Closed

Clarify equals() #63

keilw opened this issue May 29, 2017 · 3 comments

Comments

@keilw
Copy link
Member

keilw commented May 29, 2017

See unitsofmeasurement/uom-se#158 but for #62

Plus refining primitive comparison so only compatible types like "floating point" or "integer" ones get compared in a resource-effective manner.

@keilw keilw changed the title Clarify equals() in JavaDoc Clarify equals() May 29, 2017
@keilw
Copy link
Member Author

keilw commented May 30, 2017

@otaviojava type checking between A and B is already applied, so would you be able to provide a reasonable number of test cases for various types?

@otaviojava
Copy link
Member

otaviojava commented May 30, 2017

That still not working on uom-se: https://github.com/unitsofmeasurement/uom-se/blob/master/src/main/java/tec/uom/se/AbstractQuantity.java#L440

Yes, a huge number is test is really important, mainly because lost precision is complicated

@keilw
Copy link
Member Author

keilw commented May 30, 2017

No because it's a separate issue ;-)
Please feel free to add tests here, as long as the build does not break every test is welcome. And can be ported quite easily from RI to SE or the other way round (except those using BigDecimal).

Despite some projects like Parfait using uom-se, there are still 4-5x more downloads of the RI in the past 12 months. Guess a majority of Parfait users gets dependencies as RPM or it could be pre-installed on some systems, so it won't show in the download statistics. Those mostly come from Maven or Gradle builds.

@keilw keilw added ready and removed in progress labels Jun 7, 2017
@keilw keilw added the wontfix label Mar 22, 2019
@keilw keilw closed this as completed Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants