Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Style Guidelines to our Contribution Guide #162

Closed
teobais opened this issue Jan 1, 2019 · 4 comments
Closed

Add Code Style Guidelines to our Contribution Guide #162

teobais opened this issue Jan 1, 2019 · 4 comments

Comments

@teobais
Copy link
Member

teobais commented Jan 1, 2019

As mentioned in #155 (this particular section) our code styling has no specific format at the moment.

Let's go for the standard one (IntelliJ formatting) and add it to our Contribution Guidelines so that we ensure consistency in the future.

I can work on this as well, but as we know, I'm not able to assign it to myself :-)

@keilw
Copy link
Member

keilw commented Jan 1, 2019

Can IntelliJ formatting also be automated? If not, then please let's stick to the Eclipse one we already got here https://github.com/unitsofmeasurement/unit-api/blob/master/src/main/config/eclipse-formatter-config.xml. If something is missing, please adjust.

@teobais
Copy link
Member Author

teobais commented Jan 1, 2019

Good point, I'll have a look at it.

@keilw keilw transferred this issue from unitsofmeasurement/unit-api Jan 20, 2019
@keilw keilw transferred this issue from unitsofmeasurement/uom-guide Jan 20, 2019
@keilw
Copy link
Member

keilw commented Jan 20, 2019

Ok this seems about the Wiki but there also should be something in the Guide Book: unitsofmeasurement/uom-guide#3

@teobais
Copy link
Member Author

teobais commented Mar 31, 2019

It looks like IntelliJ does not provide automated formatting the way Eclipse does. Thus, the only way for Teams which are using more than 1 IDEs is to import the already existing settings file that we have.

Hence, closing this one, but it would be good to mention this required setting at unitsofmeasurement/uom-guide#3 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants