Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Telnet TTYPE Option (Terminal Type) #126

Open
mystiker opened this issue Nov 4, 2024 · 2 comments · May be fixed by #128
Open

Implement Telnet TTYPE Option (Terminal Type) #126

mystiker opened this issue Nov 4, 2024 · 2 comments · May be fixed by #128
Assignees
Labels
backend This issue is specific to the backend qualify Issues that need to be discussed further

Comments

@mystiker
Copy link
Collaborator

mystiker commented Nov 4, 2024

Description:
Implement support for the Telnet TTYPE (Terminal Type) option to allow the client to communicate its terminal type to the server. This option is mainly used to identify the "name" of the application providing the terminal.

Details:

  1. Option Code: 24

  2. Functionality:

    • Upon negotiation, the server will request the terminal type by sending a TTYPE SEND command.
    • The client should respond with a fixed terminal type value of "webmud3b" using IS, as per specification.
  3. Expected Workflow:

    • The client should recognize IAC DO TTYPE from the server and respond with IAC WILL TTYPE to agree on TTYPE usage.
    • When receiving IAC SB TTYPE SEND IAC SE, the client should respond with IAC SB TTYPE IS "webmud3b" IAC SE.
  4. Acceptance Criteria:

    • The client successfully responds with "webmud3b" as the terminal type when requested by the server.
    • The client handles repeated requests for terminal type correctly, as some servers may periodically re-request this information.

References:

Additional Notes:
Ensure that the TTYPE negotiation process does not interfere with other negotiated options and that the client’s response timing aligns with the server’s request.

@mystiker mystiker added qualify Issues that need to be discussed further backend This issue is specific to the backend labels Nov 4, 2024
@mystiker mystiker linked a pull request Nov 4, 2024 that will close this issue
@mystiker
Copy link
Collaborator Author

I made the terminal type name ("webmud3b") configurable via an environment variable NAME. This will allow distinguishing between locally and remotely deployed clients, ensuring greater flexibility and adaptability in deployment scenarios.

@myonara
Copy link
Contributor

myonara commented Nov 25, 2024

ok for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue is specific to the backend qualify Issues that need to be discussed further
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants