-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-doc has run-on sentences #2422
Comments
@natestemen Is this what you were referring to? |
Not really. I was thinking we could take inspiration from how numpy documents |
See #2472 for a related issue and potentially a solution that could fix both. 🐦⬛🐦⬛ 🥌 |
I want to help, how can i assist? |
The goal here is to go through the docstrings and ensure |
Hi @cosenal @purva-thakre ! I tried adding linespaces between the sentences in the list in |
@Shivansh20128 Thanks for testing this. Interesting that the newlines carry over in the rendered file, e.g., the one betwenn "...select the" and then "non-Clifford...". |
I agree with this. I do not know which tool would be preferable etc. I will defer to other maintainers of this project for their opinion as I won't be responsible for the long-term upkeep of documentation dependencies. |
So shall I make the changes I mentioned or wait for a method for automatic formatting? |
I think natestemen has already tried to find how numpy handles this issue automatically. I have tried also, but couldn't find anything explicit. Maybe we can write a custom command in Makefile to do it. |
@Shivansh20128 I like what you've started so far! Let's just try to find all the cases like this for now and ensure they are correctly rendered. Since we've looked and there wasn't something that automatically formatted the docstrings easily, lets fix this and focus our efforts elsewhere. |
As we rely on google-style docstrings, there is no convention to allow lists in the description of the different sections of a docstring. Portions of our API-doc have run-on sentences because someone used a list in the section description which appears as badly formatted sentences publicly.
The text was updated successfully, but these errors were encountered: