Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept changes to test results #363

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

oyvindhagberg
Copy link
Contributor

This PR does two things:

  • Test results for some API calls have changed slightly (the updated field is true for Zones, and the order of hostgroups changed) and we haven't been able to determine why this happened. This PR just accepts the changes into testsuite-results.json for now. e8b2c6d
  • Keep created and updated timestamps in the log. diff.py will ignore the contents of the fields, but it is nice to test that the fields are there and in the correct format. d24171f

Now that diff.py is able to ignore changes in date/timestamps, let's add
back created and updated fields in the test result.
@oyvindhagberg oyvindhagberg self-assigned this Dec 11, 2024
@oyvindhagberg oyvindhagberg merged commit d24171f into master Dec 12, 2024
18 checks passed
@oyvindhagberg oyvindhagberg deleted the accept-changes-to-test-results branch December 12, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants