This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Update tslint-eslint-rules to the latest version 🚀 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.1.0 of tslint-eslint-rules just got published.
The version 4.1.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of tslint-eslint-rules.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 40 commits.
25656e4[docs] v4.1.09135a0aMerge pull request #225 from buzinas/benchmarkf7d6aa3Merge pull request #226 from buzinas/new-rules-docs6eb0608[docs] update CONTRIBUTING page to state that rules must have ter prefixaad88fb[style] changed benchMark to BenchMark962ab5c[comment] added comment explaining why we need parameter2c549e2[typo] meant all lowercaseadc48eeMerge branch 'master' into benchmarkfdf0230Merge pull request #223 from jogit82/changeRulesType5beea54Merge pull request #218 from buzinas/updates9335b5a[revert] I used an all optional object so no need to explicitly declare them203a323Changed type to Array[true][false] affecting 2 rules in tslint.json66ab079Merge branch 'master' into updates5177312[enhancement] turned on noImplicitAny rule6f8ce27Merge pull request #221 from reduckted/valid-jsdoc-location-fixThere are 40 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴