Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support NaN #64

Merged
merged 1 commit into from
Dec 31, 2018
Merged

fix: support NaN #64

merged 1 commit into from
Dec 31, 2018

Conversation

unional
Copy link
Owner

@unional unional commented Dec 31, 2018

fix: fail when the expectation is not an array but subject is an empty array

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         178    184    +6     
  Branches       33     37    +4     
=====================================
+ Hits          178    184    +6
Impacted Files Coverage Δ
src/createSatisfier.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d31d560...ebefd0f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ebefd0f on nan into d31d560 on master.

@unional unional merged commit 27e906d into master Dec 31, 2018
@unional unional deleted the nan branch December 31, 2018 10:15
@unional
Copy link
Owner Author

unional commented Dec 31, 2018

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants