Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose createCallRecord #26

Merged
merged 3 commits into from
Jan 11, 2018
Merged

feat: expose createCallRecord #26

merged 3 commits into from
Jan 11, 2018

Conversation

unional
Copy link
Owner

@unional unional commented Jan 11, 2018

Use this function to create an instance of CallRecord in memory.
On top of the data, a CallRecord instance has a tersify() method to ensure when stringifing it using tersify(), all data in the CallRecord will be preserved.

Use this function to create an instance of CallRecord in memory.
On top of the data, a CallRecord instance has a `tersify()` method to ensure when stringifing it using `tersify()`, all data in the CallRecord will be preserved.
Change the expose to CallRecord.create.
And fix tersifing it.
@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling d5a6be9 on createCallRecord into 19e4218 on master.

@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      9    +1     
  Lines         136    142    +6     
  Branches       27     29    +2     
=====================================
+ Hits          136    142    +6
Impacted Files Coverage Δ
src/spy.ts 100% <ø> (ø) ⬆️
src/CallRecord.ts 100% <100%> (ø)
src/createCallRecordCreator.ts 100% <100%> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e4218...d5a6be9. Read the comment docs.

@unional unional merged commit e21f7fe into master Jan 11, 2018
@unional unional deleted the createCallRecord branch January 11, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants