-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #663 #696
fixes #663 #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GustavoGB! We'll also need to add a code snippet:
python scripts/generate_pip_deps_from_conda.py
To sync the dependencies from environment.yml
to requirements-dev.txt
We should also add a note about adding the dependencies in setup.py
.
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 39 39
Lines 3756 3756
=======================================
Hits 3696 3696
Misses 60 60
Continue to review full report at Codecov.
|
hey @GustavoGB would you mind rebasing your changes onto |
thanks for the contribution @GustavoGB ! |
No description provided.