Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #663 #696

Merged
merged 6 commits into from
Dec 14, 2021
Merged

fixes #663 #696

merged 6 commits into from
Dec 14, 2021

Conversation

GustavoGB
Copy link
Contributor

No description provided.

Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GustavoGB! We'll also need to add a code snippet:

python scripts/generate_pip_deps_from_conda.py

To sync the dependencies from environment.yml to requirements-dev.txt

We should also add a note about adding the dependencies in setup.py.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #696 (0d6af42) into master (7664092) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          39       39           
  Lines        3756     3756           
=======================================
  Hits         3696     3696           
  Misses         60       60           
Impacted Files Coverage Δ
pandera/engines/engine.py 98.82% <ø> (ø)
pandera/engines/numpy_engine.py 100.00% <ø> (ø)
pandera/engines/pandas_engine.py 98.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7664092...0d6af42. Read the comment docs.

@cosmicBboy
Copy link
Collaborator

hey @GustavoGB would you mind rebasing your changes onto master branch? there's an issue with the linters that's fixed on master

@cosmicBboy cosmicBboy merged commit 15fb49c into unionai-oss:master Dec 14, 2021
@cosmicBboy
Copy link
Collaborator

thanks for the contribution @GustavoGB !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants