Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining unrecognized numpy dtypes #637

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

jeffzi
Copy link
Collaborator

@jeffzi jeffzi commented Sep 27, 2021

This PR ensures the support of the exhaustive list of numpy dtypes that are compatible with pandas:

  • add support for numpy.bytes_
  • fix platform-specific numpy dtypes (fix TypeError when using numpy.intc #633)
  • add a test based on numpy.np.sctypeDict (contains all numpy aliases and types).

@jeffzi jeffzi changed the title Bugfix/numpy dtypes Fix remaining unrecognized numpy dtypes Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #637 (cc4f82c) into dev (1085259) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #637   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files          30       30           
  Lines        3386     3391    +5     
=======================================
+ Hits         3347     3352    +5     
  Misses         39       39           
Impacted Files Coverage Δ
pandera/engines/numpy_engine.py 100.00% <100.00%> (ø)
pandera/engines/pandas_engine.py 99.30% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1085259...cc4f82c. Read the comment docs.

@cosmicBboy
Copy link
Collaborator

thanks @jeffzi !

@cosmicBboy cosmicBboy merged commit 239e33a into unionai-oss:dev Sep 28, 2021
cosmicBboy pushed a commit that referenced this pull request Nov 11, 2021
* add test for all pandas-compatible numpy dtypes

* add support for np.bytes_

* add support for rare object aliases

* add support for platform-specific numpy dtypes
cosmicBboy pushed a commit that referenced this pull request Nov 11, 2021
* add test for all pandas-compatible numpy dtypes

* add support for np.bytes_

* add support for rare object aliases

* add support for platform-specific numpy dtypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants