coerce=True and pandas_dtype=None should be a noop #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before these two options were incompatible and pandera would raise a SchemaInitError. This diff loosens this by allowing for this combination, in which case no coercion will happen if pandas_dtype=None
Codecov Report
@@ Coverage Diff @@
## dev #476 +/- ##
======================================
Coverage ? 99.45%
======================================
Files ? 21
Lines ? 2568
Branches ? 0
======================================
Hits ? 2554
Misses ? 14
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Apr 30, 2021
cosmicBboy
added a commit
that referenced
this pull request
May 5, 2021
* coerce=True and pandas_dtype=None should be a noop before these two options were incompatible and pandera would raise a SchemaInitError. This diff loosens this by allowing for this combination, in which case no coercion will happen if pandas_dtype=None * ignore python=3.7 pandas=0.25.3 in noxfile, minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #471
before these two options were incompatible and pandera
would raise a SchemaInitError. This diff loosens this by
allowing for this combination, in which case no coercion
will happen if pandas_dtype=None