Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check_types decorator should return results from validate #458

Merged
merged 1 commit into from
Apr 14, 2021
Merged

fix check_types decorator should return results from validate #458

merged 1 commit into from
Apr 14, 2021

Conversation

jeffzi
Copy link
Collaborator

@jeffzi jeffzi commented Apr 11, 2021

Fixes #457

@codecov
Copy link

codecov bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #458 (b103e27) into dev (56250c8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #458   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          21       21           
  Lines        2572     2572           
=======================================
  Hits         2558     2558           
  Misses         14       14
Impacted Files Coverage Δ
pandera/decorators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56250c8...b103e27. Read the comment docs.

@jeffzi jeffzi requested a review from cosmicBboy April 12, 2021 15:36
cosmicBboy
cosmicBboy approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cosmicBboy cosmicBboy merged commit 80863f0 into unionai-oss:dev Apr 14, 2021
@cosmicBboy cosmicBboy mentioned this pull request Apr 14, 2021
Closed
3 tasks
cosmicBboy pushed a commit that referenced this pull request May 5, 2021
@cosmicBboy
fix check_types decorator should return results from validate (#458)
a69d36f
@jeffzi jeffzi deleted the bugfix/457 branch July 11, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicBboy cosmicBboy cosmicBboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffzi @cosmicBboy