feat: add pyarrow list and struct to pandas engine #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
===========================================
- Coverage 94.28% 82.60% -11.68%
===========================================
Files 91 117 +26
Lines 7013 8715 +1702
===========================================
+ Hits 6612 7199 +587
- Misses 401 1516 +1115 ☔ View full report in Codecov by Sentry. |
|
hey @aaravind100 mind rebasing this onto main? the failing docs build should go away after that |
Sure, let me push the update. |
aaravind100
force-pushed
the
ajith/pyarrow-list-struct
branch
from
0b0c6e5 to
ea10f2b
Compare
|
can we add some unit tests for these two new types? |
aaravind100
force-pushed
the
ajith/pyarrow-list-struct
branch
from
0ecace4 to
e03af72
Compare
Signed-off-by: Ajith Aravind <[email protected]>
Signed-off-by: Ajith Aravind <[email protected]>
aaravind100
force-pushed
the
ajith/pyarrow-list-struct
branch
from
e03af72 to
23462f1
Compare
Signed-off-by: Ajith Aravind <[email protected]>
|
@cosmicBboy I've added two tests |
cosmicBboy
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pyarrow list and struct types to pandas engine. Per #1676