Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backwards compatibility measures for type engine #539

Closed
cosmicBboy opened this issue Jul 2, 2021 · 1 comment
Closed

add backwards compatibility measures for type engine #539

cosmicBboy opened this issue Jul 2, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@cosmicBboy
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The purpose of this is to minimize backwards compatibility issues incurred by the new type engine:

Describe the solution you'd like

  1. Add back the Column(pandas_dtype=...) kwarg (to exist alongside dtype arg)
    • user cannot specify both pandas_dtype and dtype
    • if using pandas_dtype, DeprecationWarning is raised telling the user to use dtype
  2. Add back PandasDtype enum that simply aliases the types that you introduced (based on issues raised at least a few people are using PandasDtype
    • DeprecationWarning is raised whenever this enum is used
@cosmicBboy cosmicBboy added the enhancement New feature or request label Jul 2, 2021
@cosmicBboy cosmicBboy changed the title add backwards compatibility for type engine add backwards compatibility measures for type engine Jul 2, 2021
@cosmicBboy cosmicBboy added this to the 0.7.0 Release milestone Jul 2, 2021
@cosmicBboy
Copy link
Collaborator Author

fixed by #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant