Implemented Extended Ivy Function API - Modf #17629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
Array API
|
Hey, @Aarsh2001 it's my first time contributing an API to Ivy. Could you please review my implementation and provide guidance if anything needs correction? |
Aarsh2001
suggested changes
Jun 28, 2023
There was a problem hiding this comment.
Hi @RakshitKumar04 , kindly implement the function in ivy/functional/ivy/experimental/elementwise.py
RakshitKumar04
force-pushed
the
FuncAPI-MODF
branch
from
20c5a9c to
b729284
Compare
|
@Aarsh2001 I have added the function to |
|
@Aarsh2001 please review my PR. |
|
Hey, @AnnaTz can you please review my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #17464