Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cumprod Instance method to Jax NumPy Frontend #14955

Merged
merged 4 commits into from
May 9, 2023

Conversation

RakshitKumar04
Copy link
Contributor

No description provided.

@RakshitKumar04
Copy link
Contributor Author

Close #14954

@RakshitKumar04
Copy link
Contributor Author

Hey, @AnnaTz Please review my PR.

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label May 5, 2023
@RakshitKumar04 RakshitKumar04 force-pushed the jax-instMeth-cumprod branch from 6e579a6 to 88b58f5 Compare May 6, 2023 16:46
@RakshitKumar04
Copy link
Contributor Author

Hey, @AnnaTz I am facing this Assertion Error in my implementation. Can you please guide me on how to resolve this.

E       AssertionError: the ground truth framework jax returned a int64 datatype while the backend paddle returned a int32 datatype
E       Falsifying example: test_jax_devicearray_cumprod(
E           dtype_and_x=(['int64'], [array([0])], 0),
E           method_flags=FrontendMethodTestFlags(
E               num_positional_args=0,
E               as_variable=[False],
E               native_arrays=[False],
E           ),
E           init_flags=FrontendMethodTestFlags(
E               num_positional_args=0,
E               as_variable=[False],
E               native_arrays=[False],
E           ),
E           frontend_method_data=FrontendMethodData(ivy_init_module=<module 'ivy.functional.frontends.jax.numpy' from '/ivy/ivy/functional/frontends/jax/numpy/__init__.py'>, framework_init_module=<module 'jax.numpy' from '/usr/local/lib/python3.8/dist-packages/jax/numpy/__init__.py'>, init_name='array', method_name='cumprod'),
E           on_device='cpu',
E           frontend='jax',
E       )
E       
E       You can reproduce this example by temporarily adding @reproduce_failure('6.70.2', b'AXicY2BkQAUAACEAAg==') as a decorator on your test case

@RakshitKumar04 RakshitKumar04 force-pushed the jax-instMeth-cumprod branch from 88b58f5 to 8eeefad Compare May 8, 2023 16:11
@RakshitKumar04
Copy link
Contributor Author

Hey, @AnnaTz I have corrected the implementation and it is passing 4 out of 5 tests.
Please take a look.

@RakshitKumar04 RakshitKumar04 requested a review from AnnaTz May 8, 2023 16:44
@AnnaTz
Copy link
Contributor

AnnaTz commented May 9, 2023

Hey, @AnnaTz I have corrected the implementation and it is passing 4 out of 5 tests. Please take a look.

I don't see any errors in the CI check. Is it failing in the paddle backend only? What is the error?

@RakshitKumar04
Copy link
Contributor Author

@AnnaTz I don't know why, but when I locally ran the tests yesterday, one of the tests didn't pass but today all 5 got passed, Sorry

@AnnaTz
Copy link
Contributor

AnnaTz commented May 9, 2023

@AnnaTz I don't know why, but when I locally ran the tests yesterday, one of the tests didn't pass but today all 5 got passed, Sorry

No worries, looks good to me! I'll merge this.

@AnnaTz AnnaTz merged commit 5019a6c into ivy-llc:master May 9, 2023
RakshitKumar04 added a commit to RakshitKumar04/ivy that referenced this pull request May 9, 2023
@RakshitKumar04 RakshitKumar04 deleted the jax-instMeth-cumprod branch June 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants