Rewrite global console to output to the language server connection console

[remcohaszing]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Problem

If the server uses the stdio protocol for communication, stdout is used for communication. However, console.log() etc statements also write to stdout. This causes the following error:

node_modules/vscode-jsonrpc/lib/common/messageReader.js:138
                    throw new Error('Header must provide a Content-Length property.');
                    ^

Error: Header must provide a Content-Length property.
    at StreamMessageReader.onData (node_modules/vscode-jsonrpc/lib/common/messageReader.js:138:27)
    at Socket.<anonymous> (node_modules/vscode-jsonrpc/lib/common/messageReader.js:122:18)
    at Socket.emit (node:events:520:28)

The language server simply shouldn’t use console.log(), but third party plugins or other third party packages might do so.

Solution

The language server can rewrite the global console, so its calls are rerouted to connection.console.

Alternatives

The output could be disabled entirely.

[wooorm]

Could this be an upstream fix?

[remcohaszing]

I created upstream issue microsoft/vscode-languageserver-node#1299. Also a pull request microsoft/vscode-languageserver-node#1301.

[remcohaszing]

This has been solved upstream. It’s a matter of waiting for a new release now.

[wooorm]

nice!