Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke some release permissions in case npm supports package based publish permission token now #71

Closed
4 tasks done
JounQin opened this issue Jan 9, 2024 · 5 comments

Comments

@JounQin
Copy link
Member

JounQin commented Jan 9, 2024

Initial checklist

Problem

The current release permission is org based, which could be a security issue, the releasers team should be as small as possible.

Solution

Idea from mdx-js/eslint-mdx#492 (comment)

Alternatives

N/A

@JounQin
Copy link
Member Author

JounQin commented Jan 9, 2024

cc @remcohaszing

I looked through https://github.com/unifiedjs/collective/blob/main/data/teams.yml, it seems you would be affected mostly, if you still want to maintain all packages under the orgs, feel free to keep the config as-is.

@JounQin
Copy link
Member Author

JounQin commented Jan 10, 2024

Or, is that possible to change some releasers' permission on specific packages? For example, I may want only https://github.com/mdx-js/eslint-mdx 's publish permission.

cc @wooorm

@wooorm
Copy link
Member

wooorm commented Jan 10, 2024

The current release permission is org based, which could be a security issue, the releasers team should be as small as possible.

Why is that a security issue?
The releasers teams are as small as possible.

Releasers teams should not be too small. Because of the bus factor: https://en.wikipedia.org/wiki/Bus_factor.

Idea from mdx-js/eslint-mdx#492 (comment)

We have 500+ repos. What improves if we remove releasers? What does tokens solve?

Or, is that possible to change some releasers' permission on specific packages? For example, I may want only mdx-js/eslint-mdx 's publish permission.

And that is why I specifically set up a token for you. Because you specifically wanted to set up automation for that repo.

@remcohaszing
Copy link
Member

I also thought about the bus factor, but TIL it has a name. Also next time there's another wave of major releases, I intend to help to speed things up.

@JounQin
Copy link
Member Author

JounQin commented Jan 10, 2024

I also thought about the bus factor, but TIL it has a name. Also next time there's another wave of major releases, I intend to help to speed things up.

That's great if you want to maintain the whole org packages, then there's nothing left to be done here. 🍻

@JounQin JounQin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants