Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding crate icu-fs-data-provider. #200

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Adding crate icu-fs-data-provider. #200

merged 3 commits into from
Aug 28, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Aug 7, 2020

Key changes in this PR:

  • Adds crate with FsDataProvider, reading ICU4X data from an internally-defined filesystem hierarchy.
  • Adds an optional export module for writing to that filesystem hierarchy.
  • Adds a binary tool to perform that export based on CLDR JSON.

@sffc sffc force-pushed the sffc-dp2 branch 2 times, most recently from 9cfe573 to 7a8569a Compare August 7, 2020 09:31
@sffc sffc force-pushed the sffc-dp3 branch 2 times, most recently from 3c658eb to 16fc13f Compare August 7, 2020 09:33
@sffc sffc marked this pull request as ready for review August 7, 2020 09:45
@sffc sffc requested a review from a team as a code owner August 7, 2020 09:45
@sffc sffc requested a review from zbraniecki August 7, 2020 09:45
@sffc
Copy link
Member Author

sffc commented Aug 7, 2020

Not sure why macOS is failing. I investigated but can't find the cause. I've re-run it a few times, and sometimes it fails in data-provider, and sometimes in locale. See #201

@sffc sffc requested a review from mihnita August 7, 2020 09:45
@sffc
Copy link
Member Author

sffc commented Aug 7, 2020

@mihnita: this is the PR where I am adding FsDataProvider that includes a JSON parser. Please review.

This was referenced Aug 8, 2020
Closed
Closed
mihnita
mihnita previously approved these changes Aug 14, 2020
View reviewed changes
@sffc sffc requested a review from echeran August 14, 2020 16:16
@zbraniecki
Copy link
Member

lgtm!

@sffc sffc linked an issue Aug 19, 2020 that may be closed by this pull request
Data schema for ICU4X #174
Closed
@sffc sffc mentioned this pull request Aug 19, 2020
Closed
echeran
echeran previously approved these changes Aug 20, 2020
View reviewed changes
components/fs-data-provider/src/manifest.rs Show resolved Hide resolved
components/fs-data-provider/src/export/aliasing.rs Outdated Show resolved Hide resolved
components/fs-data-provider/src/export/fs_exporter.rs Show resolved Hide resolved
components/fs-data-provider/src/fs_data_provider.rs Outdated Show resolved Hide resolved
components/fs-data-provider/src/manifest.rs Show resolved Hide resolved
@sffc sffc mentioned this pull request Aug 22, 2020
Merged
Base automatically changed from sffc-dp2 to master August 28, 2020 02:27
@sffc sffc dismissed stale reviews from zbraniecki, echeran, and mihnita August 28, 2020 02:27

The base branch was changed.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Cargo.toml is different
  • components/cldr-json-data-provider/Cargo.toml is no longer changed in the branch
  • components/cldr-json-data-provider/README.md is no longer changed in the branch
  • components/cldr-json-data-provider/src/cldr_langid.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/cldr_paths.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/error.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/lib.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/reader.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/support.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/transform/mod.rs is no longer changed in the branch
  • components/cldr-json-data-provider/src/transform/plurals.rs is no longer changed in the branch
  • components/cldr-json-data-provider/tests/testdata/plurals.json is no longer changed in the branch
  • components/data-provider-json/Cargo.toml is no longer changed in the branch
  • components/data-provider-json/src/lib.rs is no longer changed in the branch
  • components/data-provider-json/src/schema.rs is no longer changed in the branch
  • components/data-provider-json/tests/test_file_io.rs is no longer changed in the branch
  • components/data-provider-json/tests/test_no_std.rs is no longer changed in the branch
  • components/data-provider-json/tests/testdata/all.json is no longer changed in the branch
  • components/data-provider/Cargo.toml is no longer changed in the branch
  • components/data-provider/src/cloneable_any.rs is no longer changed in the branch
  • components/data-provider/src/data_entry.rs is no longer changed in the branch
  • components/data-provider/src/data_key.rs is no longer changed in the branch
  • components/data-provider/src/data_provider.rs is no longer changed in the branch
  • components/data-provider/src/decimal.rs is no longer changed in the branch
  • components/data-provider/src/error.rs is no longer changed in the branch
  • components/data-provider/src/invariant.rs is no longer changed in the branch
  • components/data-provider/src/iter.rs is no longer changed in the branch
  • components/data-provider/src/lib.rs is no longer changed in the branch
  • components/data-provider/src/structs/decimal.rs is no longer changed in the branch
  • components/data-provider/src/structs/mod.rs is no longer changed in the branch
  • components/data-provider/src/structs/plurals.rs is no longer changed in the branch
  • components/data-provider/tests/json_warehouse.rs is no longer changed in the branch
  • components/fs-data-provider/src/export/fs_exporter.rs is different
  • components/fs-data-provider/tests/testdata/json_plurals_37/manifest.json is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7962266712385e86f4fa3648ed85a18e876cdb46-PR-200

  • 97 of 272 (35.66%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-5.3%) to 79.54%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/fs-data-provider/src/manifest.rs 4 8 50.0%
components/fs-data-provider/src/export/serializers.rs 20 26 76.92%
components/fs-data-provider/src/fs_data_provider.rs 18 29 62.07%
components/fs-data-provider/src/export/fs_exporter.rs 52 76 68.42%
components/fs-data-provider/src/error.rs 3 31 9.68%
components/fs-data-provider/src/export/aliasing.rs 0 35 0.0%
components/fs-data-provider/src/bin/icu4x-cldr-export.rs 0 67 0.0%
Totals Coverage Status
Change from base Build 2ef36b8d7fb8d201cbc79fa27999810ce717c935: -5.3%
Covered Lines: 2041
Relevant Lines: 2566
💛 - Coveralls

@sffc sffc merged commit 3ebc97d into master Aug 28, 2020
@sffc sffc deleted the sffc-dp3 branch August 28, 2020 05:36
@sffc sffc mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki left review comments

@mihnita mihnita mihnita left review comments

@echeran echeran echeran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data schema for ICU4X
5 participants
@sffc @zbraniecki @coveralls @echeran @mihnita