Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PluralRules to not parse strings at runtime #854

Closed
sffc opened this issue Jul 13, 2021 · 2 comments
Closed

Change PluralRules to not parse strings at runtime #854

sffc opened this issue Jul 13, 2021 · 2 comments
Labels
C-pluralrules Component: Plural rules duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality

Comments

@sffc
Copy link
Member

sffc commented Jul 13, 2021

We should be able to store plural rules strings pre-parsed in Bincode files, like we do with datetime patterns and skeletons.
@sffc sffc added T-core Type: Required functionality discuss Discuss at a future ICU4X-SC meeting C-pluralrules Component: Plural rules S-medium Size: Less than a week (larger bug fix or enhancement) labels Jul 13, 2021
@sffc sffc mentioned this issue Jul 13, 2021
Closed
@sffc sffc added good first issue Good for newcomers help wanted Issue needs an assignee and removed discuss Discuss at a future ICU4X-SC meeting labels Jul 29, 2021
@sffc sffc added this to the ICU4X 0.5 milestone Jul 29, 2021
@sffc
Copy link
Member Author

sffc commented Jul 29, 2021

  • @zbraniecki - It makes sense to do this.
  • @nordzilla - Does this mean moving the pattern parsing into the data provider?
  • @sffc - It means storing the pre-parsed rules in the data provider. The parsing code could remain where it is, or it could be hidden by a feature flag like provider_transform_utils in @gregtatum's work on DateTimeFormat.

@sffc
Copy link
Member Author

sffc commented Sep 16, 2021

Duplicate of #615

@sffc sffc marked this as a duplicate of #615 Sep 16, 2021
@sffc sffc closed this as completed Sep 16, 2021
@sffc sffc added the duplicate This issue or pull request already exists label Sep 16, 2021
@sffc sffc removed this from the ICU4X 0.5 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-pluralrules Component: Plural rules duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sffc