-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement calendrical calculations (meta-issue) #534
Comments
One suggestion for whoever ends up implementing this feature: there's an placeholder implementation of calendar calculations in the existing Temporal polyfill. The implementation itself IMHO doesn't have much value (it's inefficient and poorly written-- I know because I wrote it!), but it'd probably be useful to review the existing impl before building the real one. Specifically:
|
Design doc for common API at https://docs.google.com/document/d/1SrI7l13bi8trFh4882_n1rHebgszzCc0M2mpMuslIMA/edit?usp=sharing |
Initial work at #827 |
#1018 is a subpart of this |
This link is outdated, please edit your comment above, @Manishearth. |
We decided in #355 to take pre-resolved calendar data when formatting. However, Temporal and other downstream clients will want to hand ICU4X an ISO date and have us convert that to a calendar-specific date. Our team is in a particularly good spot to implement this logic.
Outline:
I made this meta-issue because I believe several smaller issues can be spun off to implement each individual calendar system. I believe each calendar system will need its own code path, although some may be able to share bits of code where possible. Most calendar systems can be implemented algorithmically, although come need data (e.g., the religious Islamic calendar); we should probably hook up DataProvider for this data.
Related: #493, which is about formatting data after we pass through the date input layer.
Sub-issues:
The text was updated successfully, but these errors were encountered: