Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up KeyedDataProvider and get_all_resc_keys() #442

Closed
Tracked by #568
sffc opened this issue Jan 8, 2021 · 7 comments · Fixed by #1599
Closed
Tracked by #568

Clean up KeyedDataProvider and get_all_resc_keys() #442

sffc opened this issue Jan 8, 2021 · 7 comments · Fixed by #1599
Assignees
@robertbastian
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2022 Q1 0.6 Sprint B

Comments

@sffc
Copy link
Member

sffc commented Jan 8, 2021

provider_cldr/src/transform/mod.rs has a lot of boilerplate that is hard to maintain. Figure out how to make it more automated. Maybe introduce a macro_rules.
@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters T-techdebt Type: ICU4X code health and tech debt labels Jan 8, 2021
@sffc sffc added this to the 2021-Q1-m1 milestone Jan 8, 2021
@sffc sffc self-assigned this Jan 8, 2021
@sffc sffc added the blocked A dependency must be resolved before this is actionable label Jan 28, 2021
@sffc
Copy link
Member Author

sffc commented Jan 28, 2021

Blocked by #415 / #451

@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Feb 3, 2021
@sffc sffc modified the milestones: 2021-Q1-m1, 2021-Q1-m2 Feb 3, 2021
@sffc sffc mentioned this issue Mar 2, 2021
Merged
@sffc sffc modified the milestones: 2021-Q1-m2, 2021-Q2-m1 Mar 12, 2021
@sffc sffc added the S-small Size: One afternoon (small bug fix or enhancement) label Apr 3, 2021
@sffc sffc added the blocked A dependency must be resolved before this is actionable label Apr 28, 2021
@sffc
Copy link
Member Author

sffc commented Apr 28, 2021

Blocked on the data lifetime work in #632, #667

@sffc sffc modified the milestones: 2021-Q2-m1, ICU4X 0.3 Apr 28, 2021
@dminor

This comment has been minimized.

Sign in to view
@sffc sffc modified the milestones: ICU4X 0.3, 2021 Q2-m3 May 13, 2021
@sffc sffc modified the milestones: 2021 Q3-m1, 2021 Q3 0.4 Sprint B Aug 11, 2021
@sffc sffc mentioned this issue Sep 14, 2021
Closed
10 tasks
@sffc sffc assigned nordzilla and unassigned sffc Sep 14, 2021
@sffc
Copy link
Member Author

sffc commented Sep 14, 2021

This is a child of #568, so assigning it to @nordzilla.

@sffc sffc modified the milestones: 2021 Q3 0.4 Sprint B, ICU4X 0.4 Sep 16, 2021
@sffc sffc modified the milestones: ICU4X 0.4, 2021 Q4 0.5 Sprint A Oct 21, 2021
@sffc sffc assigned sffc and unassigned nordzilla Oct 21, 2021
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Nov 18, 2021
@sffc
Copy link
Member Author

sffc commented Dec 21, 2021

Consider something like this:

pub trait KeyedDataProvider2 {
    const KEYS: &[&ResourceKey];
}

sffc added a commit to sffc/omnicu that referenced this issue Dec 30, 2021
@sffc
Move KeyedDataProvider to CLDR crate (see unicode-org#442)
3507c52
@sffc sffc mentioned this issue Dec 30, 2021
Merged
@sffc
Copy link
Member Author

sffc commented Dec 31, 2021

nit: i'd call this chainable_supports_key() or something, the or_else makes it feel like it's doing something else, whereas it really means that it's supposed to be used inside or_else.

(i know this is an existing naming choice, but i just noticed it. feel free to ignore)

Originally posted by @Manishearth in #1455 (comment)

@sffc sffc mentioned this issue Feb 2, 2022
Merged
3 tasks
@sffc
Copy link
Member Author

sffc commented Feb 4, 2022

Blocked on #1512

@sffc sffc added the blocked A dependency must be resolved before this is actionable label Feb 4, 2022
@sffc sffc modified the milestones: 2022 Q1 0.6 Sprint B, ICU4X 0.6 Feb 4, 2022
@sffc sffc assigned robertbastian and unassigned sffc Feb 9, 2022
@robertbastian robertbastian linked a pull request Feb 16, 2022 that will close this issue
Removing KeyedDataProvider from CLDR #1599
Merged
@sffc sffc modified the milestones: ICU4X 0.6, 2022 Q1 0.6 Sprint B Feb 16, 2022
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertbastian robertbastian

Labels
C-data-infra Component: provider, datagen, fallback, adapters S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2022 Q1 0.6 Sprint B
Development

Successfully merging a pull request may close this issue.

Removing KeyedDataProvider from CLDR robertbastian/icu4x
4 participants
@dminor @sffc @robertbastian @nordzilla