Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate icu_properties to ResourceProvider #1560

Closed
sffc opened this issue Jan 29, 2022 · 1 comment · Fixed by #1862
Closed

Migrate icu_properties to ResourceProvider #1560

sffc opened this issue Jan 29, 2022 · 1 comment · Fixed by #1862
Assignees
@sffc
Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2022 Q2 0.6 Sprint F

Comments

@sffc
Copy link
Member

sffc commented Jan 29, 2022

In #1554, I'm splitting DataProvider into ResourceProvider and DynProvider. I temporarily put icu_properties on DynProvider, but I would like to migrate it to ResourceProvider like most of the other components.
@sffc sffc added C-unicode Component: Props, sets, tries v1 T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) labels Jan 29, 2022
This was referenced Jan 29, 2022
Merged
Closed
@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Feb 4, 2022
@sffc sffc mentioned this issue Feb 4, 2022
Closed
@sffc sffc added the blocked A dependency must be resolved before this is actionable label Mar 3, 2022
@sffc
Copy link
Member Author

sffc commented Mar 3, 2022

Blocked on #1577

@sffc sffc removed discuss Discuss at a future ICU4X-SC meeting blocked A dependency must be resolved before this is actionable labels Mar 31, 2022
@sffc sffc added this to the 2022 Q2 0.6 Sprint F milestone Mar 31, 2022
@sffc sffc self-assigned this Mar 31, 2022
@sffc sffc removed the v1 label Apr 1, 2022
@sffc sffc mentioned this issue May 25, 2022
Merged
@sffc sffc closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2022 Q2 0.6 Sprint F
Development

Successfully merging a pull request may close this issue.

Migrating properties to ResourceProvider robertbastian/icu4x
1 participant
@sffc