Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty "unreleased" section #62

Closed
datenreisender opened this issue Aug 23, 2017 · 5 comments
Closed

Allow empty "unreleased" section #62

datenreisender opened this issue Aug 23, 2017 · 5 comments

Comments

@datenreisender
Copy link

We always keep an unreleased section in our CHANGELOG.md, it is just empty for releases. With #43 this is now prevented. It would be nice, if an empty unreleased section is allowed and only if there is stuff in it, an error is shown.

@ungoldman
Copy link
Owner

ungoldman commented Aug 23, 2017

I see! I think if the unreleased section is empty it makes sense to allow it.

I think all that would be needed is to modify the block linked to below to check if the unreleased section has a non-empty body property.

https://github.com/hypermodules/gh-release/blob/master/bin/lib/get-defaults.js#L22-L26

I will try to get this feature added soon, but in the meantime a PR is welcome 😄

@jrmykolyn
Copy link
Contributor

@ungoldman @datenreisender

Happy to take a crack at this?

@ungoldman
Copy link
Owner

@jrmykolyn please do if you have time 👍

@jrmykolyn
Copy link
Contributor

Hey @ungoldman. I submitted PR #67 against this issue.

@ungoldman
Copy link
Owner

Thanks @jrmykolyn! This feature has been released in v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants