Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to resolve security vuln #5

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Conversation

jgravois
Copy link

https://nodesecurity.io/advisories/566

same as: ungoldman/gh-release#72

i don't have push access to this repo though.

@jgravois
Copy link
Author

tests are passing on travis for my fork...
https://travis-ci.org/jgravois/gh-release-assets/builds/372171651

@paulcpederson
Copy link
Collaborator

I checkout out your branch and the tests passed, so no LGTM

@paulcpederson paulcpederson merged commit b306f35 into ungoldman:master Apr 27, 2018
@paulcpederson
Copy link
Collaborator

Thanks, @jgravois ! ❤️ ✨

@jgravois jgravois deleted the patch-1 branch April 27, 2018 19:54
@jgravois
Copy link
Author

thx @paulcpederson!

any chance you could publish this as v1.1.2 or give me the 🔑s to take care of it? we're consuming in arcgis-rest-js and i'm tackling security vulnerability nags there.

@paulcpederson
Copy link
Collaborator

@bcomnes @ungoldman what do you think about adding @jgravois as an honorary hypermodules member?

@ungoldman
Copy link
Owner

@jgravois You are cordially invited!

@jgravois
Copy link
Author

jgravois commented Apr 27, 2018

You are cordially invited!

thank you!

curtsy

released as v1.1.2 on GitHub. i encountered a ☠️ 403 when i ran npm publish

@ungoldman
Copy link
Owner

@jgravois hey, sorry about that. I added you as a collaborator on npm as well

@ungoldman
Copy link
Owner

I ran npm publish, 1.1.2 is on npm now. 🌈

@jgravois
Copy link
Author

much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants