Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Bufferize commands (activity start for ex) while the remote is waking up #411

Open
1 task done
albaintor opened this issue Nov 28, 2024 · 2 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@albaintor
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Actually when the remote wakes up, it restarts all the services :

  1. Wifi driver (wether the driver is in standby mode or completely off)
  2. Bluetooth driver
  3. Internal integrations
  4. External & custom integrations

Meanwhile, if the user tries to process a command : entity command, activity start..., an error is raised as soon as the related integrations are unavailable.
From the logs we can see this kind of messages :
[uc_denon_driver] Error connecting to driver ws://127.0.0.1:8092: ServiceUnavailable("Failed to connect to host: Connection refused (os error 111)")

And especially when a command on a given integration occurs :
[Salon TV Orange] error executing activity command sonyavr_driver.main.media_player.5501824:media_player.on (ignore error: false): sonyavr_driver session not available

A red error message appears on the screen then.

A proposed solution :

  • Add a new option on the remote "Bufferize commands and process them during startup or wakeup"
  • Eventually add another option to skip errors in startup/stop sequences of activities (at activity level) : this option could helpful when an entity is failing but it is not a big deal for later usage
  • When processing commands (start activity sequence, execute a standalone command for a given entity) : if the entity is exposed by an integration which is not started yet and not connected (the core should be able to know which integrations are starting, started or not started yet) => wait for the integration to be loaded and running the commands when available
  • Add a "X" cross icon on the screen to abort the command / or sequence if it takes too much time

This new behaviour is close to the harmony's behaviour : startup/stop sequences wait for devices to be available (bluetooth connections in that case) and after a while, a cross is displayed to abort if it takes a too long time

Image

How to Reproduce

  1. Start an activity after lifting the remote which is asleep
  2. The start sequence will fail eventually if it concerns an integration which is not loaded yet

Expected behavior

  1. Start an activity
  2. For each commands in the start sequence, wait for the integration to be fully loaded if the command is related to this integration not started yet
  3. Display a cross to abort sequence in case the user finds it too long

System version

No response

What part of the system affected by the problem?

No response

Additional context

No response

@albaintor albaintor added the bug Something isn't working label Nov 28, 2024
@github-project-automation github-project-automation bot moved this to Reported in Bug reports Nov 28, 2024
@albaintor albaintor changed the title [bug] Bufferize commands (activity start for ex) while the remote is waking up [Feature] Bufferize commands (activity start for ex) while the remote is waking up Nov 28, 2024
@albaintor albaintor changed the title [Feature] Bufferize commands (activity start for ex) while the remote is waking up [feature request] Bufferize commands (activity start for ex) while the remote is waking up Nov 28, 2024
@albaintor
Copy link
Author

Sorry, this some kind of duplicate of #389
I just added more details of potential improvements

@apgr
Copy link

apgr commented Nov 29, 2024

This would be a huge usability upgrade for non technical family members! 1000% endorsement from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Reported
Development

No branches or pull requests

2 participants