Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OpenZeppeling Base64 implementation #8

Open
haltakov opened this issue Dec 15, 2021 · 3 comments
Open

Switch to OpenZeppeling Base64 implementation #8

haltakov opened this issue Dec 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@haltakov
Copy link
Contributor

haltakov commented Dec 15, 2021

Currently, we are using an implementation for Base64 encoding for the tokenURI copied from the Loot project: https://etherscan.io/address/0xff9c1b15b16263c61d017ee9f65c50e4ae0113d7#code#L1609

There is an open issue in OpenZeppeling to add an officially supported Base64 library: OpenZeppelin/openzeppelin-contracts#2859. There is a candidate PR with an active discussion, so the library may be added soon.

If OpenZeppeling adds a Base64 library, we should switch to it.

Remember to remove the exclude statement for the Base64 contract for the slither job in the CI:

slither . --exclude-dependencies --exclude-informational --compile-force-framework hardhat --filter-paths=contracts/Base64.sol --exclude=external-function

@haltakov haltakov added the enhancement New feature or request label Dec 15, 2021
@haltakov haltakov added this to the Bnomial NFT Launch milestone Dec 15, 2021
@kfischer-okarin
Copy link

OpenZeppelin/openzeppelin-contracts#2884

Seems it was merged 8 days ago... So maybe it's possible now?

@haltakov
Copy link
Contributor Author

haltakov commented Jan 9, 2022

The Base64 contract is merged in the OpenZeppeling repo, but has not yet been released. The planned release version is 4.5. We need to wait just a little bit more :)

@haltakov
Copy link
Contributor Author

During the implementation of the SVG rendering, I switched the Base64 implementation from the old one (copied from Loot) with the one from OpenZeppelin 4.5. After 4.5 is released, the switch should be very easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants