Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor unit test #24

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

yk-saito
Copy link
Contributor

@yk-saito yk-saito commented Aug 8, 2023

変更内容

コントラクトのテストスクリプトを更新しました。

背景

実装してほしい機能(スパムを防ぐためのクールダウン)をコメントアウトすることによって通るテスト、となってしまっているため。

Screen Shot 2023-08-08 at 17 21 48
ETH-dApp section4 lesson1

その他

PRが問題なければ、マージされ次第CodeBuild上での動作確認&教材に反映いたします🙇

@yk-saito yk-saito added the enhancement New feature or request label Aug 8, 2023
@yk-saito yk-saito requested a review from a team August 8, 2023 08:27
@yk-saito yk-saito self-assigned this Aug 8, 2023
Copy link
Member

@neila neila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

素晴らしいですね!LGTM 💪🏽

@yk-saito yk-saito merged commit 530fce2 into complete Aug 8, 2023
3 checks passed
@yk-saito yk-saito deleted the feature/refactor-unit-test branch August 8, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants