Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kelon performance metrics #79

Closed
containerpope opened this issue Jan 3, 2020 · 2 comments
Closed

Kelon performance metrics #79

containerpope opened this issue Jan 3, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request S Small issue

Comments

@containerpope
Copy link
Collaborator

containerpope commented Jan 3, 2020

Problem Statement

Common questions asked when operating the system are:

  • Are there an increase in failures while executing policies ?
  • Are policies performing poorly? -> Increase in latency ?

Suggested Solution

To answer all these questions easily, we can implement prometheus metrics that represent exactly that information.
Suggestion would be to provide (counter & summary) metrics for each processed request with the following labels:

  • package
  • request path
  • request method
  • result (granted, denied, error)

This would allow to monitor latency and error rate of kelon.

@containerpope containerpope added enhancement New feature or request S Small issue labels Jun 28, 2020
@containerpope containerpope self-assigned this Jun 28, 2020
@containerpope
Copy link
Collaborator Author

@dcseifert what do you think?

@containerpope containerpope changed the title Extend kelon with web and database metrics Kelon performance metrics Jun 28, 2020
@containerpope
Copy link
Collaborator Author

Decided not to include request path and package, result is represented by status code if toggled. Also removed database metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request S Small issue
Projects
None yet
Development

No branches or pull requests

2 participants