Roundcube 1.2 (proposed fix)

[iotaka]

Hello,

you have to change
https://github.com/umount/message_label/blob/master/message_label.php#L878

In 1.1 the function was deprecated. And in 1.2 they removed it.

public function imap_connect() { return $this->storage_connect(); }

So if you call storage_connect() instead of imap_connect() is all fine.

@alecpl can you signal it in the change log for the 1.2?

[mckaygerhard]

hey, u mean that storage_connect() 0.9, 1.X and 1.2 release all work fine?

i wnat to made plugins repo and i interesting in this

[alecpl]

Yes, but in this case would be better to use get_storage() method (connection will be established automatically when needed).

[pboesch]

Hi, thanks for the fix. I have something like that:

function label_preferences($args) {
    if ($args['section'] == 'label_preferences') {

        $this->rc = rcmail::get_instance();
        //$this->rc->imap_connect();
        function imap_connect() { return $this->get_storage(); }

I have remove public from line because of that:
[23-May-2016 12:44:33 Europe/Paris] PHP Parse error: syntax error, unexpected 'public' (T_PUBLIC) in /srv/www/roundcube/plugins/message_label/message_label.php on line 884

I have yet errors:

[23-May-2016 12:48:57 +0200]: <nq34i99n> Warning: Call to deprecated function Q(); See bc.inc for replacement
[23-May-2016 12:48:57 Europe/Paris] PHP Fatal error:  Call to a member function list_folders_subscribed() on null in /srv/www/roundcube/plugins/message_label/message_label.php on line 935

Do you have a fix for that ?

Thanks for share!

PS: roundcube 1.2.0 stable

[mckaygerhard]

hi @kiwiASRALL please can do u test in roundcube version 1.1.X ? please!

[pboesch]

With 1.1.5 it's works

[mckaygerhard]

i thinks the problem its the declaration, due in the proposed fix try to redefined an older function but seems api still try to use it from internal core..

maybe if declare private and use it internally with "this"? i dont know too much of php but seems the problem its redefinition context

[pboesch]

Maybe.. But I am bad in PHP.

Someone have an update to fix all issues with RC 1.2 ?

[mckaygerhard]

please, if somebody have and updated! please dont forgive support for 0.9, 1.0 and 1.1!

[pboesch]

#31