From 7ccf522d7df6f15ef24c72ec8dcd0916ad644c3a Mon Sep 17 00:00:00 2001
From: Peach <scdzwyxst@gmail.com>
Date: Thu, 11 Apr 2024 17:56:24 +0800
Subject: [PATCH] fix: wrong react-dom server api for worker ssr mode (#12263)

* fix: wrong react-dom server api for worker ssr mode

* refactor: rename config

* refactor: correct logic

* fix: locked stream in ssr
---
 packages/preset-umi/src/features/ssr/ssr.ts | 32 +++++++++++++++++++++
 packages/server/src/ssr.ts                  | 17 +++++++----
 2 files changed, 43 insertions(+), 6 deletions(-)

diff --git a/packages/preset-umi/src/features/ssr/ssr.ts b/packages/preset-umi/src/features/ssr/ssr.ts
index 128a9de01944..59def10b65a9 100644
--- a/packages/preset-umi/src/features/ssr/ssr.ts
+++ b/packages/preset-umi/src/features/ssr/ssr.ts
@@ -17,6 +17,7 @@ export default (api: IApi) => {
   const webpackBuilder: typeof import('./webpack/webpack') = importLazy(
     require.resolve('./webpack/webpack'),
   );
+  let serverBuildTarget: string;
 
   api.describe({
     key: 'ssr',
@@ -25,6 +26,7 @@ export default (api: IApi) => {
         return zod
           .object({
             serverBuildPath: zod.string(),
+            serverBuildTarget: zod.enum(['express', 'worker']),
             platform: zod.string(),
             builder: zod.enum(['esbuild', 'webpack']),
             renderFromRoot: zod.boolean(),
@@ -49,6 +51,36 @@ export default (api: IApi) => {
     logger.warn(`SSR feature is in beta, may be unstable`);
   });
 
+  api.modifyDefaultConfig((memo) => {
+    if (serverBuildTarget === 'worker') {
+      const oReactDom = memo.alias['react-dom'];
+
+      // put react-dom after react-dom/server
+      delete memo.alias['react-dom'];
+
+      // use browser version of react-dom/server for worker mode
+      // ref: https://github.com/facebook/react/blob/f86afca090b668d8be10b642750844759768d1ad/packages/react-server-dom-webpack/package.json#L52
+      memo.alias['react-dom/server$'] = winPath(
+        join(
+          api.service.configDefaults.alias['react-dom'],
+          'server.browser.js',
+        ),
+      );
+      memo.alias['react-dom'] = oReactDom;
+    }
+
+    return memo;
+  });
+
+  api.modifyConfig((memo) => {
+    // define SSR_BUILD_TARGET to strip useless logic
+    memo.define ??= {};
+    serverBuildTarget = memo.define['process.env.SSR_BUILD_TARGET'] =
+      memo.ssr.serverBuildTarget || 'express';
+
+    return memo;
+  });
+
   api.addMiddlewares(() => [
     async (req, res, next) => {
       const modulePath = absServerBuildPath(api);
diff --git a/packages/server/src/ssr.ts b/packages/server/src/ssr.ts
index fb26a6eaa92d..f65a0bc86dfe 100644
--- a/packages/server/src/ssr.ts
+++ b/packages/server/src/ssr.ts
@@ -288,10 +288,17 @@ export default function createRequestHandler(
 
     const replaceServerHTMLScript = `<script>!function(){var e=document.getElementById("${SERVER_INSERTED_HTML}");e&&(Array.from(e.children).forEach(e=>{document.head.appendChild(e)}),e.remove())}();</script>`;
 
-    if (typeof FetchEvent !== 'undefined' && args[0] instanceof FetchEvent) {
+    if (process.env.SSR_BUILD_TARGET === 'worker') {
       // worker mode
       const [ev, workerOpts] = args as IWorkerRequestHandlerArgs;
       const { pathname, searchParams } = new URL(ev.request.url);
+      let asyncRespondWith: (
+        v: Parameters<FetchEvent['respondWith']>[0],
+      ) => void;
+
+      // respondWith must be called synchronously
+      // ref: https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/respondWith
+      ev.respondWith(new Promise((r) => (asyncRespondWith = r)));
 
       ret = {
         req: {
@@ -316,7 +323,7 @@ export default function createRequestHandler(
             res = await workerOpts.modifyResponse(res);
           }
 
-          ev.respondWith(res);
+          asyncRespondWith(res);
         },
         async sendPage(jsx) {
           const [JSXProvider, serverInsertedHTMLCallbacks] = createJSXProvider(
@@ -346,9 +353,7 @@ export default function createRequestHandler(
             },
           });
 
-          stream.pipeThrough(transformStream);
-
-          let res = new Response(stream, {
+          let res = new Response(stream.pipeThrough(transformStream), {
             headers: {
               'content-type': 'text/html; charset=utf-8',
             },
@@ -360,7 +365,7 @@ export default function createRequestHandler(
             res = await workerOpts.modifyResponse(res);
           }
 
-          ev.respondWith(res);
+          asyncRespondWith(res);
         },
         otherwise() {
           throw new Error('no page resource');