Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit tests failed due to 'tslib' missing #2636

Closed
wants to merge 2 commits into from

Conversation

DannySu09
Copy link
Contributor

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Tried to run unit tests and found two were failed due to the same reason:

image

After installing tslib, seems everything works fine:

image

@vercel
Copy link

vercel bot commented Aug 25, 2023

@sunaiwen is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: 466e918

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DannySu09 DannySu09 changed the title fix: unit test failed due to 'tslib' missing fix: unit tests failed due to 'tslib' missing Aug 25, 2023
@kuitos
Copy link
Member

kuitos commented Aug 27, 2023

CI竟然一直是好的,有点怪

@kuitos
Copy link
Member

kuitos commented Aug 28, 2023

看了一下,之前的 CI 也是 ok 的,感觉是你本地 ts 版本的问题?
不过 review 发现 tslib 是没必要开的 https://github.com/umijs/qiankun/blob/master/tsconfig.json#L9 ,感谢提醒~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants