Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 keep dynamic stylesheet inserted order by insertBefore #2574

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Aug 7, 2023

antd5 的 cssinjs 方案是通过 insertBefore 方式插入样式的,这时候会根据 referenceNode 为基准来决定插入位置,而不是无脑插入到 head 或 body 底部,此时需要提前记录地待 referenceNode 的位置信息,以便 remount 时根据位置还原现场

@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 4:04am

@kuitos kuitos merged commit 69759a5 into master Aug 7, 2023
@kuitos kuitos deleted the fix/antd5-insert-before branch August 7, 2023 06:19
@kuitos kuitos changed the title 🐛 keep dynamic stylesheet inserted order by insertBefore way 🐛 keep dynamic stylesheet inserted order by insertBefore Aug 7, 2023
@kuitos kuitos mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant