fix clearInterval bug for ie 10 and 11 #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinhailishi
changed the title
|
Could you pls revert the unrelated changes? |
Could you tell me what is the unrelated change? I just think all is needed. |
kuitos
reviewed
Jun 10, 2021
kuitos
requested changes
Jun 10, 2021
gongshun
reviewed
Jun 16, 2021
| afterMount = [], | ||
| beforeMount = [], | ||
| beforeLoad = [], | ||
| } = mergeWith({}, getAddOns(global, assetPublicPath), lifeCycles, (v1, v2) => concat(v1 ?? [], v2 ?? [])); |
| offGlobalStateChange, | ||
| }: Record<string, CallableFunction> = getMicroAppStateActions(appInstanceId); | ||
| const { onGlobalStateChange, setGlobalState, offGlobalStateChange }: Record<string, CallableFunction> = | ||
| getMicroAppStateActions(appInstanceId); |
kuitos
requested changes
Jun 16, 2021
| afterMount = [], | ||
| beforeMount = [], | ||
| beforeLoad = [], | ||
| } = mergeWith({}, getAddOns(global, assetPublicPath), lifeCycles, (v1, v2) => concat(v1 ?? [], v2 ?? [])); |
kuitos
requested changes
Jun 16, 2021
kuitos
previously approved these changes
Jun 16, 2021
kuitos
reviewed
Jun 16, 2021
kuitos
reviewed
Jun 16, 2021
kuitos
changed the title
ok @kuitos |
kuitos
added a commit
that referenced
this pull request
May 29, 2022
Co-authored-by: Kuitos <[email protected]>
|
现在还在用qiankun 吗？用的怎么样？ @xinhailishi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
调用的对象无效并且{ strictStyleIsolation: true }时，ie10、11下自动弃用ShadowDOM降级报错。 #1489