🐛 document.head.removeChild should be hooked in sandbox (#2522)

umijs · Jun 7, 2023 · 521efb8 · 521efb8 · vercel · Jun 7, 2023
1 parent cf0ee02
commit 521efb8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts b/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts
@@ -95,6 +95,7 @@ function patchDocument(cfg: { sandbox: SandBox; speedy: boolean }) {
                     const qiankunHead = getAppWrapperHeadElement(containerConfig.appWrapperGetter());
                     qiankunHead.appendChild = HTMLHeadElement.prototype.appendChild;
                     qiankunHead.insertBefore = HTMLHeadElement.prototype.insertBefore;
+                    qiankunHead.removeChild = HTMLHeadElement.prototype.removeChild;
                     return qiankunHead;
                   }
                   break;
@@ -247,13 +248,13 @@ export function patchStrictSandbox(
   // all dynamic style sheets are stored in proxy container
   const { dynamicStyleSheetElements } = containerConfig;
 
-  const unpatchDocument = patchDocument({ sandbox, speedy: speedySandbox });
-
   const unpatchDynamicAppendPrototypeFunctions = patchHTMLDynamicAppendPrototypeFunctions(
     (element) => elementAttachContainerConfigMap.has(element),
     (element) => elementAttachContainerConfigMap.get(element)!,
   );
 
+  const unpatchDocument = patchDocument({ sandbox, speedy: speedySandbox });
+
   if (!mounting) calcAppCount(appName, 'increase', 'bootstrapping');
   if (mounting) calcAppCount(appName, 'increase', 'mounting');