Unable to move grid block

[AaronSadlerUK]

As seen on the forum here:
https://our.umbraco.com/packages/website-utilities/umf/bug-reports/104700-this-content-is-now-allowed-here-prevents-reordering, this breaks one of the main and fundamental reasons for using grid.

The post is for an earlier version, however it still exists in 8.10.2.+

It seems it is not possible to drag and drop grid blocks if allow all editors is enabled.

The workaround for now involves commenting out a line in a core file:

  /*if (area.$allowedEditors) {
      allowedEditors = (allowedEditors ?? []).concat(area.$allowedEditors.map(e => e.alias));
  }*/

src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js

[nul800sebastiaan]

I don't know if that's the exact fix but it would be good to investigate what that if statement does and how it should be ammended. 👍

[umbrabot]

Hi @AaronSadlerUK,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[AaronSadlerUK]

@nul800sebastiaan surely this is a core bug, given that one of the fundamental features of grid is the drag and drop?

[nul800sebastiaan]

Hi @AaronSadlerUK, certainly it's a core bug. The way we work with incoming bug reports is usually: if we broke it recently then we fix it. If it's been broken for a long time then it seems not many people are running into the problem, we kindly ask for some help in getting it fixed.
While we would love to dive in an fix each and every bug on the issue tracker, that unfortunately doesn't scale, so we rely on the help of our community for some of this.

[AaronSadlerUK]

I noticed 3 people last night having the same issue on Facebook, others as on the forum post are also running into this issue.
It might be that editors haven't reported it (we know that happens a lot).

Just concerned that this seems to have been around a while, and as such won't be picked up and fixed in a timely manner.
Unfortunately I don't know angular otherwise I would look into it.

Fingers crossed it gets fixed 🤞

[bjarnef]

I wonder if this may be related to #9825 which has PR #9887

The previous checklist-model https://vitalets.github.io/checklist-model/ worked a bit different, which auto-populated an array using checklist-value.

Actually I could only find this reference of checklist-model, so maybe something to consider to remove in v9 or in rebuild of backoffice UI: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/common/directives/components/forms/checklistmodel.directive.js#L3-L6

[AaronSadlerUK]

The bodge in 8.10.2 is slightly different to above:

The following line needs commenting out (L18923 of umbraco.controller.js):

$scope.$apply(function () {
     area.dropNotAllowed = true;
});
ui.placeholder.hide();
cancelMove = true;

[AaronSadlerUK]

Just to update, this issue also happens when editors are manually selected

[patrickdemooij9]

Took a look at this today. The issue seems to be that .allow does not take the option "Allow all editors" into account. It's better to be using $allowedEditors because it combines the results based on .allow & .allowAll here: https://github.com/umbraco/Umbraco-CMS/blob/v8/contrib/src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/grid.controller.js#L848
PR: #10086