Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug defining editors allowances inside grid layout [inside grid data type] #9931

Closed
catiarodriguescosta opened this issue Mar 3, 2021 · 3 comments

Comments

@catiarodriguescosta
Copy link

catiarodriguescosta commented Mar 3, 2021

Umbraco version

I am seeing this issue on Umbraco version: 8.11.1

Bug summary

When you have editing your grid data type, you can more than one grid layout and more than one row.
A big potential here is that inside each grid layout you can define the number of columns and define which rows can appear as options in each column of that grid layout.

Let's assume I have a grid layout named "Grid with right sidebar" composed by 1 column of 8 and 1 column of 4.
I have 3 rows: 1 column row, 2 columns row and sidebar row.
The idea is having the smaller column (the sidebar column - 4) with only one option of row (sidebar) and the body column (the one with 8) with only 2 options of row (all except the sidebar row).
So resuming, in theory, clicking over the 8 column you can restrict it to the first two rows. and if you click back you can restrict it to the last row only. But that doesn't happen... When you save both columns has the same row restrictions.
However, if you decide to allow all the rows for the first column and restrict rows for the second column, that works.
This way, you can choose sidebar, 1 column row and 2 columns row for the body column and just sidebar for the sidebar column.

Conclusion:

I believe this is a bug because you allow to have different conditions for each column. What doesn't work is having different restrictions for each column.

Screenshot 2021-03-03 at 13 52 09

Screenshot 2021-03-03 at 13 52 23

Actual result

Screenshot 2021-03-03 at 13 46 39

Expected result

Screenshot 2021-03-03 at 13 46 39 copy

Steps to reproduce

  1. Create a new grid Data type
  2. Create a grid layout with 2 columns
  3. Create 2 different rows
  4. Edit the grid layout you created before. Try to restrict one row into one column and the other into the other column.
  5. Save and check if your restrictions are saved as you expected.
  6. You will see that something happened and the last allowed row is the one chosen in both columns (you expect to have a different option for each column).
  7. Change one of the column to allow all editors. And save. You'll realize that one column will allow both rows and the other only one, as expected.
@bjarnef
Copy link
Contributor

bjarnef commented Mar 3, 2021

I think this is a duplicate of #9825 which have a PR in #9887

//cc @nul800sebastiaan

@catiarodriguescosta
Copy link
Author

You are right @bjarnef, it's the same issue.
Do you have an idea when this fix will be merged/released?
Thanks!

@nul800sebastiaan
Copy link
Member

Yep, thanks! I believe it's in our current sprint so hopefully soon, subscribe to the other issue for updates! I'll close this one as a duplicate, thanks for reporting! 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants