Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media picker should support a minimum and a maximum number of items. #4922

Closed
madsrasmussen opened this issue Mar 8, 2019 · 5 comments
Closed

Comments

@madsrasmussen
Copy link
Contributor

Today it is only possible to select whether a media picker is allowed to choose one item or multiple items. I would love to see the same settings as in the Multinode tree picker where you can specify the minimum and a maximum number of allowed items.

@kjac
Copy link
Contributor

kjac commented Mar 9, 2019

There's a migration challenge here. Having "Minimum number of items" and "Maximum number of items" there's no longer any need for "Pick multiple items". Which means... how to migrate?

A suggested approach could be:

  • If "Pick multiple items" is set to true, both "Minimum number of items" and "Maximum number of items" should be set to 0 (no limits).
  • If "Pick multiple items" is set to false, "Minimum number of items" should be set to 0 and "Maximum number of items" should be set to 1.

@nul800sebastiaan
Copy link
Member

Oh no, never replied to this 🙈 Someone asked about it and this sounds sensible to me, taking @kjac's suggestions into account.

I think the only concern might be that we'd need to update Deploy to support these new options as well, I am not sure they will be picked up automatically.

And then there's a migration issue as well, not sure if Deploy will pick up on the migrated content. Anyway, we can figure that out later. For now it would be great to work on, sure!

@nul800sebastiaan
Copy link
Member

Feedback on the Deploy part: this is no problem, Deploy will pick up on the new config with no problem. So ignore my concerns! 👍

@bjarnef
Copy link
Contributor

bjarnef commented Jan 13, 2021

I think this is similar to the configuration changes I suggested in #8471

Maybe "Disable folder select" would also be obsolete if we instead can configurate allowed media types 👍

@emma-hq
Copy link
Contributor

emma-hq commented Mar 9, 2021

Hey folks,

I'm going to close this one as a duplicate of #8471,

Emma

@emma-hq emma-hq closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants