Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Version Cleanup #17861

Closed
IOSven opened this issue Dec 23, 2024 · 3 comments
Closed

Content Version Cleanup #17861

IOSven opened this issue Dec 23, 2024 · 3 comments
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug

Comments

@IOSven
Copy link

IOSven commented Dec 23, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.5.2

Bug summary

When save & publishing pages, the Prevent version cleanup value is automatically set to true. This behavior is unexpected, as we do not intend for this setting to be enabled by default. Additionally, in dbo.umbracoLog, we observe the log entries growing each time the page is re-published with the following logComment:
set preventCleanup = 'True' for version '3397359'.

Specifics

ContentVersionCleanupPolicy is enabled in appsettings:

"Umbraco": {
    "CMS": {
        "Content": {
            "ContentVersionCleanupPolicy": {
                "EnableCleanup": true,
                "KeepAllVersionsNewerThanDays": 4,
                "KeepLatestVersionPerDayForDays": 80
            }
        }
    }
}

History cleanup > prevent cleanup is disabled (default) for each document type.

Steps to reproduce

In our project we save & publish a new page.
We notice that the first 2 save & publish actions have 'prevent cleanup' setting is set to false
However, for subsequent actions, it defaults to true.

image

Each time the page is re-published, the umbracoLog table grows, with the following log comment being added repeatedly:

image

EDIT:
I've done some more research. We've got UMarketingSuite v 2.5.1 installed on our project.
This issue is only occuring when a document type has been marked as 'allow segmentation'.

Disabling this toggle does not reset the cleanup policy logic.

Expected result / actual result

When publishing pages, the 'Prevent version cleanup' setting is automatically set to true. We expect that enabling ContentVersionCleanupPolicy in the app settings will automatically set the Prevent version cleanup value to false, allowing the Umbraco cron job ContentVersionCleanupJob to clean up content versions as intended.

Copy link

Hi there @IOSven!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @IOSven , could you reproduce this on a fresh install? or give us clear steps and reproduce?
I tested on v13.6.0-rc, and didn't see any error here. My default config EnableCleanup : true and published my Content a few times,
the history always displays like this, which means all versions have enabled Cleanup
image

@NguyenThuyLan NguyenThuyLan added the state/needs-more-info We don't have enough information to give a good reply label Dec 26, 2024
@IOSven
Copy link
Author

IOSven commented Jan 2, 2025

Hi @NguyenThuyLan,

After a long debugging session, I’ve pinpointed the issue.
We’re using Jumoo Translation Manager, which we recently updated from version 10.3.1 to 13.1.3.

It seems that a new feature introduced in version 13.1.0, “Preserve versions of content (prevent cleanup) that are used in translations,” is causing some unexpected issues on our end.

To address this, we’ll be creating a new issue in the Jumoo package GitHub repository to report the problem and gather further insights or solutions.

@IOSven IOSven closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-more-info We don't have enough information to give a good reply type/bug
Projects
None yet
Development

No branches or pull requests

2 participants