Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.ArgumentNullException: Value cannot be null. (Parameter 'user') #17701

Open
PeterKvayt opened this issue Dec 2, 2024 · 2 comments
Open
Labels
affected/v13 area/backend state/reproduced state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@PeterKvayt
Copy link
Contributor

PeterKvayt commented Dec 2, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.8.7

Bug summary

If you are not logged in in umbraco backoffice and trying to get resource by url: "domain.com/umbraco/backoffice/umbracoapi/content/GetById?id=1451", you will get System.ArgumentNullException: Value cannot be null. (Parameter 'user').

изображение

I think there is something wrong with this code, look at signature. IUser is nullable and at the same time there is a null check.

I think there is should be non nullable IUser or logic with nullable IUser.

Specifics

No response

Steps to reproduce

  1. Create some content
  2. Logout from backoffice
  3. Try to get this content useing following link: "domain.com/umbraco/backoffice/umbracoapi/content/GetById?id=your content id"
  4. Look at logs

Expected result / actual result

Expected result: there is no error "System.ArgumentNullException: Value cannot be null. (Parameter 'user')" in logs. Maybe more suitable is to handle this case with 404 or 401 status code response and there is should be consistent signature for CheckPermissions method.

Actual result: there is "System.ArgumentNullException: Value cannot be null. (Parameter 'user')" error in logs


This item has been added to our backlog AB#46947

Copy link

github-actions bot commented Dec 2, 2024

Hi there @PeterKvayt!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

I was able to reproduce it on v13.5.2

@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v13 area/backend state/reproduced state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

3 participants