v14-rc1 - setting tags datatypes Storage Type to Csv or Json, causes content page to not load or not save

[KevinJump]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v14-rc1

Bug summary

Settings the "Storage Type" value of the Tags datatype causes JSON errors either on load or on Save of a content page (it depends if you have already created the page or not).

Specifics

It looks like the functionality works if you don't change the 'storage type' setting because the default is a not set value, but once the value is set it breaks.

Steps to reproduce

• Create a Tags data type.

• Save it

• Change the storage type to Csv

• Save It

• Change it back to Json

• Save it.

• Create or view an existing page that uses a document type with the Tag data type on it.,

Page will either fail to load with the error:

The configuration for data type 1041 : Umbraco.Tags is invalid (see inner exception). Please fix the configuration and ensure it is valid. The site may fail to start and / or load data types and run.

or when you save the page will hand, and the error below will be in the logs

 An unhandled exception has occurred while executing the request.
System.InvalidOperationException: The configuration for data type -87 : Umbraco.RichText is invalid (see inner exception). Please fix the configuration and ensure it is valid. The site may fail to start and / or load data types and run.
 ---> System.InvalidOperationException: Failed to parse configuration "System.Collections.Generic.Dictionary`2[System.String,System.Object]" as "RichTextConfiguration" (see inner exception).
 ---> System.FormatException: String "069ef55e-6a88-4deb-9d2c-60df36b6eece" is not a valid udi.
   at Umbraco.Cms.Core.UdiParser.ParseInternal(String s, Boolean tryParse, Boolean knownTypes, Udi& udi)
   at Umbraco.Cms.Core.UdiParser.Parse(String s)
   at Umbraco.Cms.Infrastructure.Serialization.JsonUdiConverter.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
   at System.Text.Json.Serialization.JsonConverter`1.ReadAsObject(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
   at System.Text.Json.Serialization.Converters.CastingConverter`1.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)

Expected result / actual result

No response

[github-actions]

Hi there @KevinJump!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[elit0451]

Hi there @KevinJump 👋

Thanks for reaching out! I can indeed reproduce this, we will have a look 🙂

[elit0451]

The error in the logs that you posted here seems to be a wrong copy/paste from another issue 😜

Here is the error we get in the logs for this issue:

System.InvalidOperationException: The configuration for data type 1055 : Umbraco.Tags is invalid (see inner exception). Please fix the configuration and ensure it is valid. The site may fail to start and / or load data types and run.
 ---> System.InvalidOperationException: Failed to parse configuration "System.Collections.Generic.Dictionary`2[System.String,System.Object]" as "TagConfiguration" (see inner exception).
 ---> System.Text.Json.JsonException: The JSON value could not be converted to Umbraco.Cms.Core.Models.TagsStorageType. Path: $.storageType | LineNumber: 0 | BytePositionInLine: 16.
   at System.Text.Json.ThrowHelper.ThrowJsonException(String message)
   at System.Text.Json.Serialization.Converters.EnumConverter`1.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 json, JsonTypeInfo`1 jsonTypeInfo)
   at System.Text.Json.JsonSerializer.Deserialize[TValue](String json, JsonSerializerOptions options)
   at Umbraco.Cms.Infrastructure.Serialization.SystemTextJsonSerializerBase.Deserialize[T](String input) in /UmbracoCMS/src/Umbraco.Infrastructure/Serialization/SystemTextJsonSerializerBase.cs:line 17
   at Umbraco.Cms.Core.PropertyEditors.ConfigurationEditor`1.ToConfigurationObject(IDictionary`2 configuration, IConfigurationEditorJsonSerializer configurationEditorJsonSerializer) in /UmbracoCMS/src/Umbraco.Core/PropertyEditors/ConfigurationEditorOfTConfiguration.cs:line 39
   --- End of inner exception stack trace ---
   at Umbraco.Cms.Core.PropertyEditors.ConfigurationEditor`1.ToConfigurationObject(IDictionary`2 configuration, IConfigurationEditorJsonSerializer configurationEditorJsonSerializer) in /UmbracoCMS/src/Umbraco.Core/PropertyEditors/ConfigurationEditorOfTConfiguration.cs:line 43
   at Umbraco.Cms.Core.Models.DataType.get_ConfigurationObject() in /UmbracoCMS/src/Umbraco.Core/Models/DataType.cs:line 104

[leekelleher]

I had a niggly feeling this was a frontend bug, so looked into it and it is. Its to do with the dropdown list used for the storageType, it saves the value as a string array, and when the server is deserializing the value (for TagConfiguration.TagsStorageType), it's expecting a string (non-array), so throws an error.

I'll fix this on the frontend repo and cross-link the PR for reference.

[leekelleher]

Cross-linking to PR for frontend fix: umbraco/Umbraco.CMS.Backoffice#1680
Tested the original scenario and the server is happy with a single string value now; no error thrown.

[leekelleher]

PR: umbraco/Umbraco.CMS.Backoffice#1680 has been merged in and will be part of upcoming v14.0.0-rc2.