V13 RC: Deleting a webhook opens up webhook side bar

[KevinJump]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v13 rc1

Bug summary

Clicking on delete on a webhook, opens up both the confirm delete webhook, and the edit webhook sidebar.

Specifics

On the webhook dashboard, if you attempt to delete a webhook via the 'delete' button, you get both the confirm overlay and the edit sidebar.

once you have deleted via the overlay, if you then click save on the open sidebar, you also get an error (because you just deleted the thing it is trying to edit.

Steps to reproduce

1. Create a webhook,
2. Delete the webhook from the dashboard.

Expected result / actual result

Only the Confirm delete webhook should be shown.

[github-actions]

Hi there @KevinJump!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

I have fixed that 😉😁😎
5ebe052

[KevinJump]

just noticed it also happens if you attempt to enable/disable the webhook on the dashboard (via the checkbox) ? not sure if that's the same code that needs fixing for that too?

[bjarnef]

No the checkbox in the list is not really a checkbox, but a checkmark 🙂
And the clicking the table row opens the edit view, but clicking the delete button shouldn't bubble to parent event.

The checkmark is also used in languages overview at default language.

[Zeegaan]

Fixed in #15077, so I will go ahead and close this 😁

I do however wonder if we could do anything about the enabling thing.. But I think it's a bigger issue in itself in general with the .
Maybe because when you hover the checkmark, it actually changes color, and therefore gives an impression that it does something when you click it? 🤔