Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13: Navigating new login screen doesn't focus buttons #15078

Closed
bjarnef opened this issue Oct 31, 2023 · 4 comments
Closed

v13: Navigating new login screen doesn't focus buttons #15078

bjarnef opened this issue Oct 31, 2023 · 4 comments

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Oct 31, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.0

Bug summary

When navigating the new login screen the focus isn't visible on login button and furthermore when navigating to reset password view.

It does seem to focus on other button looks, but difficult to see with default look.

Specifics

No response

Steps to reproduce

Navigate login screen via keyboard.

Expected result / actual result

No response


This item has been added to our backlog AB#34430

Copy link

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

@bjarnef Thanks for reporting this. If I'm not mistaken, this would actually be an issue with the UI Library, or what do you think?

@bjarnef
Copy link
Contributor Author

bjarnef commented Nov 2, 2023

@iOvergaard yes, have a look here at the different button looks.
https://uui.umbraco.com/?path=/docs/uui-button--docs

When look is "primary" it is very difficult to see the button has focus, but when hover the button, it's a bit more clear the button has focus.

However I also noticed when navigation from login form to forgot password the focus seems to be lost and it starting focus browser address bar hitting tabs key, where I would expect the focus was within the login layout.

@iOvergaard
Copy link
Contributor

You are right, @bjarnef. I see it as two separate issues. I'll say we should be able to fix the focus on navigation, e.g. to the reset password page. The other thing with focusable buttons will have to be fixed in the UI library, so I'll go ahead and reference your comment in a new issue on that repo.

@iOvergaard iOvergaard added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks state/reproduced affected/v13 area/frontend labels Nov 3, 2023
@iOvergaard iOvergaard removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants