Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svg as an Image mediatype by default #10604

Closed
nul800sebastiaan opened this issue Jul 6, 2021 Discussed in #10602 · 3 comments
Closed

Add svg as an Image mediatype by default #10604

nul800sebastiaan opened this issue Jul 6, 2021 Discussed in #10602 · 3 comments

Comments

@nul800sebastiaan
Copy link
Member

nul800sebastiaan commented Jul 6, 2021

Discussed in #10602

Originally posted by sigrundis July 6, 2021

Umbraco Version

8.14

Description

When uploading an SVG it is uploaded as media type File instead of Image or the like.

@nul800sebastiaan
Copy link
Member Author

nul800sebastiaan commented Jul 6, 2021

From the discussion:

this is due to SVG by default not being set as an image file type. In order to preserve backwards compatibility, we currently can't change that (people expecting SVG to be created as a File will suddenly get different behavior.

This seems like a good one to fix for v9, adding svg here and mark it as breaking change: https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Core/Configuration/UmbracoSettings/ContentImagingElement.cs#L17

I'll put this as up for grabs to fix in v9, accepting svg as an image by default.

@umbraco umbraco deleted a comment from sigrundis Jul 7, 2021
@nul800sebastiaan nul800sebastiaan changed the title Choose media type before uploading media through content section Add svg as an Image mediatype by default Jul 7, 2021
@JamieTownsend84
Copy link

@nul800sebastiaan hey - I am looking at 'up for grabs' issues, this one appears to be resolved in v9 so not sure if you want to mark this issue as closed now?

@nul800sebastiaan
Copy link
Member Author

Thanks @JamieTownsend84 - with the new media picker this is now handled appropriately in both v8 and v9 👍 Time to close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants