Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.14-RC: Rename Media Picker V3 to Media Picker #10321

Closed
hemraker opened this issue May 25, 2021 · 4 comments · Fixed by #10332
Closed

8.14-RC: Rename Media Picker V3 to Media Picker #10321

hemraker opened this issue May 25, 2021 · 4 comments · Fixed by #10332

Comments

@hemraker
Copy link
Member

hemraker commented May 25, 2021

In the releases candidate for Umbraco 8.14 the new Media Picker (#9461) is listed as Media Picker v3. I find this slightly confusing as there are no v1 and v2, just a Media Picker.
image
image

I don't see a case where one would not use the new Media Picker going forward (it's too good 😉), so I would suggest naming it Media Picker. The "old" Media Picker could be named Media Picker (Legacy) or Media Picker (Old) and still be available for backwards compatibility until it's deprecated.


This item has been added to our backlog AB#12109

@rasmusjp
Copy link
Member

Maybe following the same naming convention as in v7 when the new pickers were introduced? The old ones were prefixed with (Obsolete) e.g. the media picker was renamed to (Obsolete) Media Picker and it was marked as deprecated, so you could only use it on an existing project were it already was in use or if you enabled oblosete editors in umbracoSettings.config

@hemraker
Copy link
Member Author

@rasmusjp I like it 😊

@nul800sebastiaan nul800sebastiaan changed the title 8.14RC: Rename Media Picker V3 to Media Picker 8.14-RC: Rename Media Picker V3 to Media Picker May 25, 2021
@nul800sebastiaan nul800sebastiaan added type/feature state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels May 25, 2021
@warrenbuckley
Copy link
Contributor

PR for review is here - #10332

@nul800sebastiaan nul800sebastiaan removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label May 26, 2021
@nul800sebastiaan
Copy link
Member

Fixed in #10332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants